better user data validation for gridftp upload view

[qcg-portal.git] / qcg / views.py

diff --git a/qcg/views.py b/qcg/views.py
index f0de4dc..adc4676 100644 (file)
--- a/qcg/views.py
+++ b/qcg/views.py
@@ -1,20 +1,25 @@
 # coding=utf-8
 from datetime import datetime, timedelta
+
 from django.conf import settings
+from django.contrib import messages
 from django.contrib.auth import REDIRECT_FIELD_NAME
 from django.contrib.auth.decorators import login_required
+from django.core.exceptions import SuspiciousOperation
 from django.core.urlresolvers import reverse
 from django.db.models import Q
-from django.http import HttpResponse
-from django.shortcuts import render, get_object_or_404
+from django.http import HttpResponse, QueryDict
+from django.shortcuts import render, get_object_or_404, redirect
+from django.utils.html import format_html
 from django.utils.http import urlencode
 from django.utils.timezone import UTC
 from django_openid_auth.views import make_consumer
 from openid.extensions import ax
-from pyqcg import QCG
 
-from qcg.forms import FiltersForm, JobDescriptionForm, EnvFormSet
-from qcg.utils import update_user_data, paginator_context
+from filex.forms import HostPathNameForm, RenameForm, ArchiveForm, HostPathForm
+from qcg.forms import FiltersForm, ColumnsForm, JobDescriptionForm, EnvFormSet
+from qcg.utils import paginator_context
+from qcg.service import update_user_data, submit_job
 
 
 def index(request):
@@ -54,8 +59,7 @@ def parse_date(string):
 
 @login_required
 def jobs_list(request):
-    # QCG.start()
-    # update_user_data(request.user, request.session['proxy'])
+    update_user_data(request.user, request.session['proxy'])
 
     tasks = request.user.tasks.order_by('-job__submission_time', '-submission_time') \
         .select_related('job').prefetch_related('allocations__nodes')
@@ -115,7 +119,19 @@ def jobs_list(request):
 
     checked_status = {i: widget.is_checked() for i, widget in enumerate(filters['status'])}
 
-    context = {'filters': filters, 'checked_status': checked_status, 'selected_filters': selected_filters}
+    columns = ColumnsForm(QueryDict(request.COOKIES.get('columns', '')))
+
+    displayed = None
+    if columns.is_valid():
+        displayed = {int(c) for c in columns.cleaned_data['columns']}
+
+    # if invalid or empty
+    if not displayed:
+        displayed = set(columns.fields['columns'].initial)
+
+    context = {'filters': filters, 'checked_status': checked_status, 'selected_filters': selected_filters,
+               'columns': ColumnsForm(initial={'columns': displayed}), 'displayed': displayed}
+
     context.update(paginator_context(request, tasks))
 
     return render(request, 'qcg/jobs.html', context)
@@ -128,6 +144,7 @@ def job_details(request, job_id):
     return render(request, 'qcg/job.html', {'job': job})
 
 
+@login_required
 def task_details(request, job_id, task_id):
     task = get_object_or_404(request.user.tasks.select_related('job').prefetch_related('allocations'),
                              job__job_id=job_id, task_id=task_id)
@@ -135,5 +152,50 @@ def task_details(request, job_id, task_id):
     return render(request, 'qcg/task.html', {'task': task})
 
 
+@login_required
 def job_new(request):
-    return render(request, 'qcg/job_new.html', {'form': JobDescriptionForm(), 'env_formset': EnvFormSet()})
+    if request.method == 'POST':
+        form = JobDescriptionForm(request.POST)
+        env_formset = EnvFormSet(request.POST)
+
+        if form.is_valid() and env_formset.is_valid():
+            params = form.cleaned_data
+            params['env_variables'] = [(env['name'], env['value'])
+                                       for env in env_formset.cleaned_data if env and not env['DELETE']]
+
+            job_id = submit_job(params, request.session['proxy'])
+
+            messages.success(request,
+                             format_html('<span class="glyphicon glyphicon-info-sign" aria-hidden="true"></span> '
+                                         'Zlecono zadanie <em>{}</em>.', job_id))
+
+            return redirect('jobs')
+
+        print repr(form.errors)
+        print repr(env_formset.errors)
+    else:
+        form = JobDescriptionForm()
+        env_formset = EnvFormSet()
+
+    errors = form.errors or (env_formset.is_bound and not env_formset.is_valid)
+
+    return render(request, 'qcg/job_new.html', {'form': form, 'env_formset': env_formset, 'errors': errors})
+
+
+@login_required
+def gridftp(request):
+    return render(request, 'qcg/gridftp.html',
+                  {'new_dir_form': HostPathNameForm(), 'rename_form': RenameForm(),  'archive_form': ArchiveForm()})
+
+
+@login_required
+def gridftp_upload(request):
+    form = HostPathForm(request.GET)
+
+    if not form.is_valid():
+        raise SuspiciousOperation('Invalid parameters for `gridftp_upload`!')
+
+    return render(request, 'qcg/gridftp_upload.html',
+                  {'url': reverse('filex:upload') + '?' + urlencode(form.cleaned_data),
+                   'host': form.cleaned_data['host'], 'path': form.cleaned_data['path'],
+                   'sep': '/' if form.cleaned_data['path'].startswith('~') else ''})